Repository navigation
Bug#39033858 Parallel_reader::Scan_ctx::copy_row copies wrong range of bytes - #96
Merged
Merged
Conversation
…f bytes Problem: InnoDB uses a convention where rec pointers point in between two fragments of the record: to the left of it, are so called "extra" bytes which contain metadata such as flags, info about which fields are null and what is their length. To the right of it, is the actual data of the fields. The function rec_offs_size(offsets) returns the total length of the record which is the sum of these two: ``` rec_offs_data_size(offsets) + rec_offs_extra_size(offsets) ``` The logic of Parallel_reader::Scan_ctx::copy_row() copied that many bytes into a freshly allocated buffer, but used rec address as the source, instead of "rec - extra", resulting in copying wrong range of bytes. Solution: Adjust the logic to copy the correct range of bytes. Change-Id: Ia0463e4a752dfce70ff5a2ac83818132de9a638c
|
Jakub Łopuszański seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #95 Bug#39033858 Parallel_reader::Scan_ctx::copy_row copies wrong range of bytes
Problem:
InnoDB uses a convention where rec pointers point in between two fragments of the record: to the left of it, are so called "extra" bytes which contain metadata such as flags, info about which fields are null and what is their length. To the right of it, is the actual data of the fields.
The function rec_offs_size(offsets) returns the total length of the record which is the sum of these two:
The logic of Parallel_reader::Scan_ctx::copy_row() copied that many bytes into a freshly allocated buffer, but used rec address as the source, instead of "rec - extra", resulting in copying wrong range of bytes.
Solution:
Adjust the logic to copy the correct range of bytes.
Change-Id: Ia0463e4a752dfce70ff5a2ac83818132de9a638c